Messages in this thread | | | Date | Wed, 4 Oct 2017 12:44:14 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v7 2/2] tracing: Add support for preempt and irq enable/disable events |
| |
On Wed, 4 Oct 2017 18:04:34 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Sep 29, 2017 at 02:22:45PM -0700, Joel Fernandes wrote: > > +++ b/kernel/trace/trace_irqsoff.c > > > EXPORT_SYMBOL(trace_hardirqs_on); > > EXPORT_SYMBOL(trace_hardirqs_off); > > EXPORT_SYMBOL(trace_hardirqs_on_caller); > > EXPORT_SYMBOL(trace_hardirqs_off_caller); > > Steve, how does this compiler with lockdep enabled? Because: > > kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on_caller); > kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_on); > kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off_caller); > kernel/locking/lockdep.c:EXPORT_SYMBOL(trace_hardirqs_off);
I'll have to see if it does, I haven't applied them yet. Looks like they were removed from the:
#ifdef CONFIG_PROVE_LOCKING
[..]
#else /* !CONFIG_PROVE_LOCKING */
<here>
#endif
I don't see the protection in the patches. I will definitely test that before pushing it anywhere.
-- Steve
| |