lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pinctrl: cherryview: fix issues caused by dynamic gpio irqs mapping
    On Tue, Oct 03, 2017 at 12:00:49PM -0500, Grygorii Strashko wrote:
    > New GPIO IRQs are allocated and mapped dynamically by default when
    > GPIO IRQ infrastructure is used by cherryview-pinctrl driver.
    > This causes issues on some Intel platforms [1][2] with broken BIOS which
    > hardcodes Linux IRQ numbers in their ACPI tables.
    >
    > On such platforms cherryview-pinctrl driver should allocate and map all
    > GPIO IRQs at probe time.
    > Side effect - "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n"
    > can be seen at boot log.
    >
    > NOTE. It still may fail if boot sequence will changed and some interrupt
    > controller will be probed before cherryview-pinctrl which will shift Linux IRQ
    > numbering (expected with CONFIG_SPARCE_IRQ enabled).
    >
    > [1] https://bugzilla.kernel.org/show_bug.cgi?id=194945
    > [2] https://lkml.org/lkml/2017/9/28/153
    > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
    > Cc: Chris Gorman <chrisjohgorman@gmail.com>
    > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
    > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
    > Reported-by: Chris Gorman <chrisjohgorman@gmail.com>
    > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>

    Looks reasonable to me. Thanks for taking care of this!

    Chris, can you try if this fixes the issue and provide your Tested-by?

    \
     
     \ /
      Last update: 2017-10-04 08:48    [W:4.796 / U:1.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site