Messages in this thread | | | Date | Tue, 31 Oct 2017 10:13:41 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing: always define trace_{irq,preempt}_{enable_disable} |
| |
On Thu, 19 Oct 2017 10:32:13 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> We get a build error in the irqsoff tracer in some configurations: > > kernel/trace/trace_irqsoff.c: In function 'trace_preempt_on': > kernel/trace/trace_irqsoff.c:855:2: error: implicit declaration of function 'trace_preempt_enable_rcuidle'; did you mean 'trace_irq_enable_rcuidle'? [-Werror=implicit-function-declaration] > trace_preempt_enable_rcuidle(a0, a1); > > The problem is that trace_preempt_enable_rcuidle() has different > definition based on multiple Kconfig symbols, but not all combinations > have a valid definition. > > This changes the conditions so that we always get exactly one > definition of each of the four tracing macros. I have not tried > to verify that these definitions are sensible, but now we > can build all randconfig combinations again. > > Fixes: d59158162e03 ("tracing: Add support for preempt and irq enable/disable events") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied. Thanks Arnd.
-- Steve
| |