lkml.org 
[lkml]   [2017]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 36/43] drm/i915/perf: fix perf enable/disable ioctls with 32bits userspace
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

    commit 7277f755048da562eb2489becacd38d0d05e1e06 upstream.

    The compat callback was missing and triggered failures in 32bits
    userspace when enabling/disable the perf stream. We don't require any
    particular processing here as these ioctls don't take any argument.

    Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
    Fixes: eec688e1420 ("drm/i915: Add i915 perf infrastructure")
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20171024152728.4873-1-lionel.g.landwerlin@intel.com
    (cherry picked from commit 191f896085cf3b5d85920d58a759da4eea141721)
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/i915_perf.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/gpu/drm/i915/i915_perf.c
    +++ b/drivers/gpu/drm/i915/i915_perf.c
    @@ -2480,6 +2480,10 @@ static const struct file_operations fops
    .poll = i915_perf_poll,
    .read = i915_perf_read,
    .unlocked_ioctl = i915_perf_ioctl,
    + /* Our ioctl have no arguments, so it's safe to use the same function
    + * to handle 32bits compatibility.
    + */
    + .compat_ioctl = i915_perf_ioctl,
    };



    \
     
     \ /
      Last update: 2017-10-31 11:03    [W:4.035 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site