Messages in this thread | | | From | Julian Calaby <> | Date | Tue, 31 Oct 2017 00:33:51 +1100 | Subject | Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template() |
| |
Hi Markus,
On Mon, Oct 30, 2017 at 7:14 AM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 29 Oct 2017 20:16:22 +0100 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Julian Calaby <julian.calaby@gmail.com>
However,
> --- > drivers/net/wireless/ti/wlcore/main.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c > index 0365b5e40a8d..12a9d6509382 100644 > --- a/drivers/net/wireless/ti/wlcore/main.c > +++ b/drivers/net/wireless/ti/wlcore/main.c > @@ -4081,9 +4078,8 @@ static int wlcore_set_beacon_template(struct wl1271 *wl, > beacon->data, > beacon->len, 0, > min_rate); > -end_bcn: > +free_skb:
Why rename the label?
Thanks,
-- Julian Calaby
Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/
| |