Messages in this thread | | | From | Jon Maloy <> | Subject | RE: [PATCH] net: tipc: Convert timers to use timer_setup() | Date | Mon, 30 Oct 2017 09:57:30 +0000 |
| |
> -----Original Message----- > From: keescook@google.com [mailto:keescook@google.com] On Behalf Of > Kees Cook > Sent: Friday, October 27, 2017 06:58 > To: Jon Maloy <jon.maloy@ericsson.com> > Cc: David S. Miller <davem@davemloft.net>; Ying Xue > <ying.xue@windriver.com>; netdev@vger.kernel.org; tipc- > discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] net: tipc: Convert timers to use timer_setup() > > On Tue, Oct 24, 2017 at 11:44 AM, Jon Maloy <jon.maloy@ericsson.com> > wrote: > > NAK. It doesn't sound like a good idea to send this to net. Especially since > one of these timers has already been refactored in net-next. > > Hi! I'm not sure what you mean about the one timer issue. I don't see any > use of timer_setup() in net/tipc (and no recent conversions to the older > setup_timer() API). What's the preferred path for landing this API conversion > in net/tipc/? > > And, just to note, these changes are almost entirely mechanical. The only > "special" case is in tipc_sk_timeout() where the argument needs to be > slightly adjusted to fetch the tsk from the sk again.
I am referring to commit 0d5fcebf3c37 ("tipc: refactor tipc_sk_timeout() function") which is in "net-next" but not yet in "net". I guess David M is the one who decides whether you deliver to net or net-next, but in the former case you will have to wait until David merges in the above commit, and then add your change again.
BR ///jon
> > Thanks! > > -Kees > > -- > Kees Cook > Pixel Security
| |