lkml.org 
[lkml]   [2017]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 28/41] btrfs: propagate error to btrfs_cmp_data_prepare caller
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Naohiro Aota <naohiro.aota@wdc.com>

    commit 78ad4ce014d025f41b8dde3a81876832ead643cf upstream.

    btrfs_cmp_data_prepare() (almost) always returns 0 i.e. ignoring errors
    from gather_extent_pages(). While the pages are freed by
    btrfs_cmp_data_free(), cmp->num_pages still has > 0. Then,
    btrfs_extent_same() try to access the already freed pages causing faults
    (or violates PageLocked assertion).

    This patch just return the error as is so that the caller stop the process.

    Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
    Fixes: f441460202cb ("btrfs: fix deadlock with extent-same and readpage")
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/ioctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/ioctl.c
    +++ b/fs/btrfs/ioctl.c
    @@ -2984,7 +2984,7 @@ static int btrfs_cmp_data_prepare(struct
    out:
    if (ret)
    btrfs_cmp_data_free(cmp);
    - return 0;
    + return ret;
    }

    static int btrfs_cmp_data(struct inode *src, u64 loff, struct inode *dst,

    \
     
     \ /
      Last update: 2017-10-03 15:13    [W:4.330 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site