Messages in this thread | | | From | Gilad Ben-Yossef <> | Date | Tue, 3 Oct 2017 13:43:53 +0300 | Subject | Re: [PATCH 2/4] staging: ccree: simplify access to struct device |
| |
On Mon, Oct 2, 2017 at 1:00 PM, Joe Perches <joe@perches.com> wrote: > On Mon, 2017-10-02 at 10:03 +0100, Gilad Ben-Yossef wrote: >> Introduce a DEV macro to retrieve struct device from private >> data structure in preparation to replacing custom logging >> macros with proper dev_dbg and friends which require struct >> device. > [] >> diff --git a/drivers/staging/ccree/ssi_driver.h b/drivers/staging/ccree/ssi_driver.h > [] >> @@ -103,6 +103,8 @@ >> #define SSI_LOG_DEBUG(format, ...) do {} while (0) >> #endif >> >> +#define DEV(drvdata) ((&(drvdata)->plat_dev->dev)) > > The name seems not particularly descriptive. > It seems a longer name would > not be too bad. > > Perhaps > > static inline struct device *drvdata_to_dev(struct ssi_drvdata *drvdata) > { > return &drvdata->plat_dev->dev; > } >
Good point.
Fixed in v2.
Thanks, Gilad
-- Gilad Ben-Yossef Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
| |