Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 29 Oct 2017 12:00:34 +0100 | Subject | Re: [PATCH] ravb: Use common error handling code in ravb_probe() |
| |
Hi Markus,
On Sat, Oct 28, 2017 at 7:19 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 28 Oct 2017 19:10:08 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/ethernet/renesas/ravb_main.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index a8822a756e08..62dbdf7de6cd 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -2069,10 +2069,9 @@ static int ravb_probe(struct platform_device *pdev) > irq = platform_get_irq_byname(pdev, "ch22"); > else > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - error = irq; > - goto out_release; > - } > + if (irq < 0) > + goto failure_indication;
IMHO, it's really confusing that "irq" contains the error code, not "error". Especially when jumping to a meaningless label named "failure_indication" ("irq_failure" would be more intuitive).
So I prefer the original code, regardless of the label name.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |