Messages in this thread | | | Date | Fri, 27 Oct 2017 22:36:01 +0300 | From | Leon Romanovsky <> | Subject | Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow() |
| |
On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small adjustment > for this source code place. > > > > I mean you aren't really making the code any smaller > > Would anybody like to check corresponding effects in more detail > after a specific function call was replaced by a goto statement?
You are supposed to do it and not "anybody".
> > > > and it's not making it any easier to read really. > > Is the code readability still good enough there? > > Regards, > Markus [unhandled content-type:application/pgp-signature] | |