Messages in this thread | | | From | Nick Desaulniers <> | Date | Fri, 27 Oct 2017 11:28:43 -0700 | Subject | Re: [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang |
| |
+ linux-kbuild@vger.kernel.org
On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > I do not like to add $(CLANG_TARGET) to a place for common helpers. > Instead of $(CLANG_TARGET), please add > $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) > to cc-ldoption and ld-option.
Thanks for the review. I agree that sounds like a better option.
> I have two requests next time: > - please include linux-kbuild@vger.kernel.org in your To list
Sure thing. scripts/get_maintainer.pl does not recommend that list for this file; is there a way to explicitly add that list to the recommendation for that source file?
> - please base your patch on linux-kbuild/kbuild branch
Will do. Do I need to note it's based off that branch? Otherwise wont 0-day bot complain that my patch doesn't apply/build on torvalds/linux ?
| |