lkml.org 
[lkml]   [2017]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] input: mxs-lradc: remove redundant assignment to pointer input
    Date
    From: Colin Ian King <colin.king@canonical.com>

    The pointer 'input' is being initialized with ts->ts_input and this
    value is not being read as it is updated a few lines later with the
    return value from the call to devm_input_allocate_device. Remove the
    redundant initialization assignment. Cleans up clang warning:

    drivers/input/touchscreen/mxs-lradc-ts.c:587:20: warning: Value Xi
    stored to 'input' during its initialization is never read

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
    index 3707e927f770..c850b517854e 100644
    --- a/drivers/input/touchscreen/mxs-lradc-ts.c
    +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
    @@ -584,7 +584,7 @@ static void mxs_lradc_ts_hw_init(struct mxs_lradc_ts *ts)

    static int mxs_lradc_ts_register(struct mxs_lradc_ts *ts)
    {
    - struct input_dev *input = ts->ts_input;
    + struct input_dev *input;
    struct device *dev = ts->dev;

    input = devm_input_allocate_device(dev);
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-10-28 20:19    [W:8.464 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site