lkml.org 
[lkml]   [2017]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a separate header
    From
    Date
    Hi Bjorn,

    Thanks for reviewing!

    On 10/26/2017 07:28 AM, Bjorn Andersson wrote:
    > On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:
    >
    >> Move the structure shared by the APCS IPC device and its subdevices
    >> into a separate header file.
    >>
    >
    > As you're creating the apcs regmap with devm_regmap_init_mmio() you can
    > just call dev_get_regmap(dev->parent) in your child to get the handle.

    Ok, thanks!

    >
    > But I would prefer that you just add the clock code to the existing
    > driver.

    This will require an ack from Stephen, and i got the impression that he
    prefers a separate clk driver [1].

    Stephen, are you ok with registering the clocks from the apcs mailbox
    driver?

    [1] https://lkml.org/lkml/2017/6/26/750

    \
     
     \ /
      Last update: 2017-10-28 20:19    [W:4.208 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site