Messages in this thread | | | Subject | Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init() | From | Dou Liyang <> | Date | Fri, 27 Oct 2017 17:38:24 +0800 |
| |
Hi Juergen
At 10/27/2017 05:21 PM, Juergen Gross wrote: > On 27/10/17 10:43, Ingo Molnar wrote: >> >> * Juergen Gross <jgross@suse.com> wrote: >> >>> Don't try to set the static virt_spin_lock_key to a value before >>> jump_label_init() has been called, as this will result in a WARN(). >>> >>> Solve the problem by introducing a new lock_init() hook called after >>> jump_label_init() instead of doing the call inside of >>> smp_prepare_boot_cpu(). >>> >>> Signed-off-by: Juergen Gross <jgross@suse.com> >>> --- >>> Based on kernel/git/tip/tip.git locking/core >> >> Just a quick ping: what's the conclusion of the discussion, do we want this patch >> as-is? > > Dou Liyang (CC-ed) suggested another alternative he wanted to test. This > would be much less intrusive. I can send a patch based on his idea in > case he doesn't react in time: he basically suggested moving the call of
I am sorry I misunderstood your comments, I thought you were going to send a new version, So I said i will test it. ;-)
Now, I understood clearly. I will do it and send a patch for this bug.
Thanks, dou
| |