Messages in this thread | | | Date | Thu, 26 Oct 2017 16:08:41 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get() |
| |
On Thu, Oct 26, 2017 at 03:54:50PM +0200, Jarkko Sakkinen wrote: > Device number (the character device index) is not a stable identifier > for a TPM chip. That is the reason why every call site passes > TPM_ANY_NUM to tpm_chip_find_get(). > > This commit changes the API in a way that instead a struct tpm_chip > instance is given and NULL means the default chip. In addition, this > commit refines the documentation to be up to date with the > implementation. > > Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> (@chip_num -> @chip) > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Jason, once you have given this reviewed-by can you do a patch set that includes this and your and PrasannaKumar's change? It could be a while before keyring and IMA maintainers have reviewed my change.
/Jarkko
| |