lkml.org 
[lkml]   [2017]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iommu: Limit the IOVA page range to the specified addresses
On Tue, 17 Oct 2017 16:22:01 -0500
Gary R Hook <gary.hook@amd.com> wrote:

> From: amd <amd@sosxen2.amd.com>
>
> The extent of pages specified when applying a reserved region should
> include up to the last page of the range, but not the page following
> the range.
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
> drivers/iommu/amd_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 27eb0d6fcdc2..bb3ef33e3784 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -3271,7 +3271,7 @@ static void amd_iommu_apply_resv_region(struct device *dev,
> unsigned long start, end;
>
> start = IOVA_PFN(region->start);
> - end = IOVA_PFN(region->start + region->length);
> + end = IOVA_PFN(region->start + region->length - 1);
>
> WARN_ON_ONCE(reserve_iova(&dma_dom->iovad, start, end) == NULL);
> }

This looks like a fix, should we include:

Fixes: 8d54d6c8b8f3 ('iommu/amd: Implement apply_dm_region call-back')


Thanks,
Alex

\
 
 \ /
  Last update: 2017-10-26 10:33    [W:0.325 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site