| Subject | Re: [PATCH 02/13] x86/paravirt: Fix output constraint macro names | From | Juergen Gross <> | Date | Wed, 25 Oct 2017 11:33:43 +0200 |
| |
On 04/10/17 17:58, Josh Poimboeuf wrote: > Some of the paravirt '*_CLOBBERS' macros refer to output constraints > instead of clobbers, which makes the code extra confusing. Rename the > output constraint related macros to '*_OUTPUTS'. > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
I'm fine with the changes, but you might want to rename the "call_clbr" parameter of ____PVOP_[V]CALL, too, e.g. to "outputs".
You could then drop the "CALL_" from the macros, too.
Juergen
|