Messages in this thread | | | Date | Wed, 25 Oct 2017 07:45:52 +1100 | From | "Tobin C. Harding" <> | Subject | Re: [PATCH v7] printk: hash addresses printed with %p |
| |
On Tue, Oct 24, 2017 at 01:25:52PM +0200, Jason A. Donenfeld wrote: > On Tue, Oct 24, 2017 at 2:31 AM, Tobin C. Harding <me@tobin.cc> wrote: > > On Tue, Oct 24, 2017 at 01:00:03AM +0200, Jason A. Donenfeld wrote: > >> Provided you've tested this and the static_key guard stuff actually > >> works as intended, > > > > I tested by inserting a simple module that calls printf() with a bunch of > > different specifiers. So it's tested but not stress tested. Some stress testing > > might be nice, no ideas how to go about that though. > > By the way, it occurred to me one thing you might want to verify > closely is whether or not that callback block executes from process > context and whether or not the static_key stuff sleeps. If both, > there's a problem.
Ok, will do.
thanks, Tobin.
| |