Messages in this thread | | | Subject | Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs | From | Santosh Shilimkar <> | Date | Tue, 24 Oct 2017 09:05:59 -0700 |
| |
On 10/24/2017 7:16 AM, Håkon Bugge wrote: > The number of unsignaled work-requests posted to the IB send queue is > tracked by a counter in the rds_ib_connection struct. When it reaches > zero, or the caller explicitly asks for it, the send-signaled bit is > set in send_flags and the counter is reset. This is performed by the > rds_ib_set_wr_signal_state() function. > > However, this function is not always used which yields inaccurate > accounting. This commit fixes this, re-factors a code bloat related to > the matter, and makes the actual parameter type to the function > consistent. > > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > --- Instead of partially doing changes inside/outside helper, can also add inline helper for solicited state like rds_ib_set_wr_solicited_state() and use that along with this change.
Regards, Santosh
| |