Messages in this thread | | | From | Bin Meng <> | Date | Tue, 24 Oct 2017 15:08:20 +0800 | Subject | Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH |
| |
Hi Mika,
On Mon, Oct 23, 2017 at 8:12 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Sun, Oct 15, 2017 at 09:38:57PM +0800, Bin Meng wrote: >> > Also, the 'depends on EXPERT' statement looks misplaced, >> > enabling EXPERT should only be there to allow you to turn >> > extra things *off*, not to hide device drivers. >> > >> >> I will leave this to Mika to comment the "EXPERT" usage. If we remove >> this, I think that should be another patch and the documentation of >> this driver should be updated too. > > Yeah, I guess we can remove that EXPERT dependency. It was added there > exactly because I did not want ordinary users playing with the device > and inadvertently overwrite their BIOSes (if it is not protected). I > also agree it should be a separate patch. Do you want to do that or > should I?
Thanks. I can prepare a patch to remove EXPERT.
Regards, Bin
| |