Messages in this thread | | | Date | Tue, 24 Oct 2017 11:25:08 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG |
| |
On Mon, Oct 23, 2017 at 01:18:57PM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
I think this patch is terrible. Why on earth is Coccinelle even warning about this?
If anything we should be converting these constructs to not use BUG.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |