Messages in this thread | | | Date | Mon, 23 Oct 2017 12:23:13 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 31/37] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer |
| |
On Mon, 23 Oct 2017, Johannes Berg wrote:
> On Sun, 2017-10-22 at 23:40 +0200, Anna-Maria Gleixner wrote: > > From: Thomas Gleixner <tglx@linutronix.de> > > > > Switch the timer to HRTIMER_MODE_SOFT, which executed the timer > > callback in softirq context and remove the hrtimer_tasklet.
I can't build as its part of the whole hrtimer rework series.
> This doesn't build on my tree, due to HRTIMER_MODE_REL_SOFT not > existing. Neither does HRTIMER_MODE_SOFT mentioned above, but that's > just a commit log mistake.
Oops.
> (It also didn't apply on my tree, but that was a trivial context > change.) > > I don't understand why you initialize it with HRTIMER_MODE_ABS_SOFT > either though: > > > + hrtimer_init(&data->beacon_timer, CLOCK_MONOTONIC, > > + HRTIMER_MODE_ABS_SOFT);
Sure, though it does not matter in that case. Will fix that up.
Thanks,
tglx
| |