lkml.org 
[lkml]   [2017]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock
From
From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Sat, 21 Oct 2017 06:51:30 +0000

> This is the possible reason for different hard to reproduce
> problems on my ARMv7-SMP test system.
>
> The symptoms are in recent kernels imprecise external aborts,
> and in older kernels various kinds of network stalls and
> unexpected page allocation failures.
>
> My testing indicates that the trouble started between v4.5 and v4.6
> and prevails up to v4.14.
>
> Using the dirty_tx before acquiring the spin lock is clearly
> wrong and was first introduced with v4.6.
>
> Fixes: e3ad57c96715 ("stmmac: review RX/TX ring management")
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>

Applied, thank you.

\
 
 \ /
  Last update: 2017-10-22 17:51    [W:0.152 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site