lkml.org 
[lkml]   [2017]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: smc_close: mark expected switch fall-throughs
From
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Sat, 21 Oct 2017 20:21:00 -0500

>
> Quoting David Miller <davem@davemloft.net>:
>
>> From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
>> Date: Thu, 19 Oct 2017 17:02:44 -0500
>>
>>> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct
>>> work_struct *work)
>>> case SMC_PEERCLOSEWAIT1:
>>> if (rxflags->peer_done_writing)
>>> sk->sk_state = SMC_PEERCLOSEWAIT2;
>>> - /* fall through to check for closing */
>>> + /* to check for closing */
>>> + /* fall through */
>>
>> Gustavo please look at what you are doing to the code.
>>
>> This was a nice easy to read sentence in the comment, and now
>> you've chopped it up into two pieces and made it awkward and
>> more difficult to read.
>
> You're right.
>
> What about this instead:
>
> /* fall through */
> /* to check for closing */

I'm surprised gcc cares if it's all on one line or not, actually.

\
 
 \ /
  Last update: 2017-10-22 17:51    [W:0.058 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site