lkml.org 
[lkml]   [2017]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 13/15] platform/x86: wmi: create userspace interface for drivers
On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> + wblock = container_of(wdev, struct wmi_block, dev);
> + if (!wblock)
> + return -ENODEV;

How can container_of() ever return NULL? If so, you have a very odd
memory layout...

> + list_for_each_entry_safe(wblock, next, &wmi_block_list, list) {
> + wdriver = container_of(wblock->dev.dev.driver,
> + struct wmi_driver, driver);
> + if (!wdriver)
> + continue;

Same here. And other places in this file.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-10-22 17:40    [W:0.853 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site