Messages in this thread | | | Date | Fri, 20 Oct 2017 13:48:27 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h |
| |
On Fri, 20 Oct 2017, Arnd Bergmann wrote: > On Fri, Oct 20, 2017 at 1:11 PM, Ingo Molnar <mingo@kernel.org> wrote: > >> #include <asm/iommu_table.h> > >> +#include <asm/x86_init.h> > >> > >> #include "irq_remapping.h" > > > > This breaks the IA64 build: > > > > drivers/iommu/dmar.c:44:26: fatal error: asm/x86_init.h: No such file or directory > > I've sent a fixup to add an #ifdef around it now. Alternatively, we > could include > it implicitly in asm/iommu_table.h, which would avoid the #ifdef but > seem a little > hacky.
Hrm. Both solutions are ugly. Is there no other way to split stuff up in those headers (maybe create an extra one).
Thanks,
tglx
| |