lkml.org 
[lkml]   [2017]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/4] reset: tegra: check BPMP response return code
    From
    Date

    On 07/09/17 10:31, Timo Alho wrote:
    > Add checks for return code in BPMP response message.
    >
    > Signed-off-by: Timo Alho <talho@nvidia.com>
    > ---
    > drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-
    > 1 file changed, 8 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
    > index 5daf2ee..fac2db6 100644
    > --- a/drivers/reset/tegra/reset-bpmp.c
    > +++ b/drivers/reset/tegra/reset-bpmp.c
    > @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
    > struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
    > struct mrq_reset_request request;
    > struct tegra_bpmp_message msg;
    > + int err;
    >
    > memset(&request, 0, sizeof(request));
    > request.cmd = command;
    > @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
    > msg.tx.data = &request;
    > msg.tx.size = sizeof(request);
    >
    > - return tegra_bpmp_transfer(bpmp, &msg);
    > + err = tegra_bpmp_transfer(bpmp, &msg);
    > + if (err < 0)
    > + return err;
    > + else if (msg.rx.ret < 0)
    > + return -EINVAL;
    > +
    > + return 0;
    > }
    >
    > static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,

    Acked-by: Jon Hunter <jonathanh@nvidia.com>

    Cheers
    Jon

    --
    nvpublic

    \
     
     \ /
      Last update: 2017-10-02 22:26    [W:2.946 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site