Messages in this thread | | | Date | Mon, 2 Oct 2017 18:24:05 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 5/7] ARM: dts: sun8i: a83t: cubietruck-plus: Add AXP818 regulator nodes |
| |
Hi,
On Fri, Sep 29, 2017 at 03:25:12AM +0000, Chen-Yu Tsai wrote: > +#include "axp81x.dtsi" > + > +®_aldo1 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vcc18-csi2-dsi-efuse-hdmi-d4dp"; > +};
I'm not really fond of these names. It's easy to miss some components (especially since we most of the time don't have the schematics), and if it's not complete, the obscure name isn't worth it either.
What about vcc-1.8 for this one ?
> +®_aldo2 { > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "vdd-drampll-vcc18-pll-adc-cpvdd-ldoin"; > +};
dram-pll?
> +®_aldo3 { > + regulator-always-on; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-name = "vcc-pl-avcc"; > +};
avcc?
etc..
> status = "disabled"; > }; > > +®_vcc3v3 { > + status = "disabled"; > +}; > + > ®_vcc5v0 { > status = "disabled"; > };
Why not simply remove the DTSI then?
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |