lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3 4/7] powerpc64: Add .opd based function descriptor dereference
    On (10/04/17 11:21), Petr Mladek wrote:
    [..]
    > > +#ifdef PPC64_ELF_ABI_v1
    > > +unsigned long dereference_module_function_descriptor(struct module *mod,
    > > + unsigned long addr)
    > > +{
    > > + if (addr < mod->arch.start_opd || addr >= mod->arch.end_opd)
    > > + return addr;
    > > +
    > > + return dereference_function_descriptor(addr);
    > > +}
    > > +#endif /* PPC64_ELF_ABI_v1 */
    >
    > I would personally move this up in the source file. It is related to
    > the definition of func_desc() and other functions that are
    > also PPC_ELF_ABI-specific.
    >
    > Otherwise, it looks good to me.
    >
    > Reviewed-by: Petr Mladek <pmladek@suse.com>

    OK, will move.

    -ss

    \
     
     \ /
      Last update: 2017-10-22 17:20    [W:4.294 / U:0.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site