lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 36/51] ceph: fix bogus endianness change in ceph_ioctl_set_layout
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jeff Layton <jlayton@redhat.com>


    [ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ]

    sparse says:

    fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64

    preferred_osd is a __s64 so we don't need to do any conversion. Also,
    just remove the cast in ceph_ioctl_get_layout as it's not needed.

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    Reviewed-by: Sage Weil <sage@redhat.com>
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ceph/ioctl.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/ceph/ioctl.c
    +++ b/fs/ceph/ioctl.c
    @@ -25,7 +25,7 @@ static long ceph_ioctl_get_layout(struct
    l.stripe_count = ci->i_layout.stripe_count;
    l.object_size = ci->i_layout.object_size;
    l.data_pool = ci->i_layout.pool_id;
    - l.preferred_osd = (s32)-1;
    + l.preferred_osd = -1;
    if (copy_to_user(arg, &l, sizeof(l)))
    return -EFAULT;
    }
    @@ -97,7 +97,7 @@ static long ceph_ioctl_set_layout(struct
    nl.data_pool = ci->i_layout.pool_id;

    /* this is obsolete, and always -1 */
    - nl.preferred_osd = le64_to_cpu(-1);
    + nl.preferred_osd = -1;

    err = __validate_layout(mdsc, &nl);
    if (err)

    \
     
     \ /
      Last update: 2017-10-22 17:24    [W:2.882 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site