lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: char/tpm: Improve a size determination in nine functions
    On Wed, 18 Oct 2017 21:03:13 +0300
    Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

    > On Wed, 2017-10-18 at 19:48 +0200, SF Markus Elfring wrote:
    > > > For 1/4 and 2/4: explain why the message can be omitted.
    >
    > > > That's all.
    > >
    > > I assume that there might be also some communication challenges
    > > involved.
    > >
    > >
    > > > 3/4: definitive NAK, too much noise compared to value.
    > >
    > > I tried to reduce deviations from the Linux coding style again.
    > > You do not like such an attempt for this software area so far.
    >
    > The problem here in a time line or what comes first. Definitely, you
    > are trying to fix the code which _is_ upstream vs. the code which
    > _might be_ upstream (exception is drivers/staging).
    >
    > Why didn't you listen to what people are telling you?
    >
    > Why are you spending too much time on little sense crap instead of
    > doing real fixes?
    >

    People are free to spend their time on what they like.

    Even if no commit of this series lands in mainline it has been useful
    to clarify what is preferred style and what is useful fix.

    Thanks

    Michal

    \
     
     \ /
      Last update: 2017-10-22 17:23    [W:4.500 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site