Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 19 Oct 2017 13:04:35 +0200 | Subject | Re: [PATCH] nfds: avoid gettimeofday for nfssvc_boot time |
| |
On Thu, Oct 19, 2017 at 12:54 PM, Jeff Layton <jlayton@redhat.com> wrote: > > I wonder if we'd be better off just using nfssvc_boot.tv_sec as the > verifier? I don't see us ever calling that ktime_get_real_ts64 more than > once per second for this purpose, and that would eliminate wraparound. > That said, wraparound is not a huge concern here anyway, so this is > certainly fine for now:
I now have the feeling that we had previously had the same discussion when someone else submitted a similar patch that ended up never getting merged. I might also be confusing this with a different subsystem that had the same requirement.
If we want this to be as unique as possible and also never (within a few hundred years) wrap, we could call ktime_get_real_ns(), which returns a 64-bit nanoseconds number.
> Reviewed-by: Jeff Layton <jlayton@redhat.com>
Thanks.
Arnd
| |