lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] printk: simplify no_printk()
Hi Petr,

2017-10-02 23:56 GMT+09:00 Petr Mladek <pmladek@suse.com>:
> On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
>> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
>> a value") surrounded the macro implementation with ({ ... }).
>>
>> Now, the inner do { ... } while (0); is redundant.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Looks fine to me. The return value is slightly more visible now ;-)
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> JFYI, I have pushed it into for-4.15 branch.
>
> Best Regards,
> Petr


A minor problem.

I think "Reviewed-by: " is missing before Sergey.

I am not sure if this is too late, or not...




commit 38a8c55325f5d4f261fde8b1bebfa2e9daf7c3e1
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Mon Sep 18 00:01:44 2017 +0900

printk: simplify no_printk()

Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
a value") surrounded the macro implementation with ({ ... }).

Now, the inner do { ... } while (0); is redundant.

Link: http://lkml.kernel.org/r/1505660504-11059-1-git-send-email-yamada.masahiro@socionext.com
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2017-10-22 17:22    [W:1.222 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site