Messages in this thread | | | Date | Thu, 19 Oct 2017 16:23:23 -0500 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] net: rxrpc: mark expected switch fall-throughs |
| |
Quoting David Howells <dhowells@redhat.com>:
> Gustavo A. R. Silva <garsilva@embeddedor.com> wrote: > >> + /* fall through */ > > All new comments in rxrpc should begin with a capital letter; I'm > switching to > this as I modify the lines with comments on. Fix checkpatch or gcc or > whatever takes -Wimplicit-fallthrough to stop being silly. > >> - /* Fall through */ >> - >> + /* fall through */ > > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's > there for a reason. >
What is the reason?
>> + /* fall through */ > > Capital 'F'. > >> - >> + /* fall through */ > > Don't remove the blank line. Capital 'F'. > >> + /* fall through */ > > Capital 'F'. > > David
Thanks -- Gustavo A. R. Silva
| |