lkml.org 
[lkml]   [2017]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: rxrpc: mark expected switch fall-throughs

Quoting David Howells <dhowells@redhat.com>:

> Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
>> + /* fall through */
>
> All new comments in rxrpc should begin with a capital letter; I'm
> switching to
> this as I modify the lines with comments on. Fix checkpatch or gcc or
> whatever takes -Wimplicit-fallthrough to stop being silly.
>
>> - /* Fall through */
>> -
>> + /* fall through */
>
> No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's
> there for a reason.
>

What is the reason?

>> + /* fall through */
>
> Capital 'F'.
>
>> -
>> + /* fall through */
>
> Don't remove the blank line. Capital 'F'.
>
>> + /* fall through */
>
> Capital 'F'.
>
> David

Thanks
--
Gustavo A. R. Silva




\
 
 \ /
  Last update: 2017-10-22 17:30    [W:2.069 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site