Messages in this thread | | | Date | Wed, 18 Oct 2017 10:47:29 -0700 | From | Felix Manlunas <> | Subject | Re: [PATCH 1/2] liquidio: remove unnecessary NULL check before kfree in delete_glists |
| |
On Tue, Oct 17, 2017 at 01:59:20PM -0500, Gustavo A. R. Silva wrote: > NULL check before freeing functions like kfree is not needed. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > This code was tested by compilation only. > > drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > index 2e993ce..e4a112c 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c > @@ -435,8 +435,7 @@ static void delete_glists(struct lio *lio) > do { > g = (struct octnic_gather *) > list_delete_head(&lio->glist[i]); > - if (g) > - kfree(g); > + kfree(g); > } while (g); > > if (lio->glists_virt_base && lio->glists_virt_base[i] && > -- > 2.7.4 >
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
| |