Messages in this thread | | | Subject | Re: [PATCH net 3/3] bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocations | From | John Fastabend <> | Date | Tue, 17 Oct 2017 09:29:26 -0700 |
| |
On 10/17/2017 07:55 AM, Daniel Borkmann wrote: > PCPU_MIN_UNIT_SIZE is an implementation detail of the percpu > allocator. Given we support __GFP_NOWARN now, lets just let > the allocation request fail naturally instead. The two call > sites from BPF mistakenly assumed __GFP_NOWARN would work, so > no changes needed to their actual __alloc_percpu_gfp() calls > which use the flag already. > > Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> > ---
Nice cleanup. Thanks!
Acked-by: John Fastabend <john.fastabend@gmail.com>
| |