Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2 4/4] watchdog: aspeed: Move init to arch_initcall | From | Andrew Jeffery <> | Date | Tue, 17 Oct 2017 22:05:58 +1030 |
| |
On Wed, 2017-09-20 at 15:43 +0930, Joel Stanley wrote: > > On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > > Probing at device_initcall time lead to perverse cases where the > > watchdog was probed after, say, I2C devices, which then leaves a > > potentially running watchdog at the mercy of I2C device behaviour and > > bus conditions. > > > > Load the watchdog driver early to ensure that the kernel is patting it > > well before initialising peripherals. > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > I agree that we need to make sure the watchdog driver is loaded > earlier. I think this is the correct method, but I'll defer to Guenter > on this one.
Just following up on Joel's comments: Is there anything else I need to address?
Cheers,
Andrew[unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |