lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 18/20] staging: lustre: osc: mark expected switch fall-through
    Date
    On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
    >
    > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    > where we are expecting to fall through.
    >
    > Addresses-Coverity-ID: 1077598
    > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

    Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

    > ---
    > drivers/staging/lustre/lustre/osc/osc_cache.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c
    > index e1207c2..eab7759 100644
    > --- a/drivers/staging/lustre/lustre/osc/osc_cache.c
    > +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
    > @@ -227,6 +227,7 @@ static int osc_extent_sanity_check0(struct osc_extent *ext,
    > rc = 65;
    > goto out;
    > }
    > + /* fall through */
    > default:
    > if (atomic_read(&ext->oe_users) > 0) {
    > rc = 70;
    > --
    > 2.7.4
    >

    Cheers, Andreas
    --
    Andreas Dilger
    Lustre Principal Architect
    Intel Corporation







    \
     
     \ /
      Last update: 2017-10-22 17:08    [W:5.285 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site