lkml.org 
[lkml]   [2017]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs
    Date
    On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
    >
    > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    > where we are expecting to fall through.
    >
    > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

    Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

    > ---
    > drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
    > index aad4ff1..a3664c1 100644
    > --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
    > +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
    > @@ -786,7 +786,7 @@ __u32 lustre_msg_get_flags(struct lustre_msg *msg)
    >
    > CERROR("invalid msg %p: no ptlrpc body!\n", msg);
    > }
    > - /* no break */
    > + /* fall through */
    > default:
    > /* flags might be printed in debug code while message
    > * uninitialized
    > @@ -854,7 +854,7 @@ __u32 lustre_msg_get_op_flags(struct lustre_msg *msg)
    >
    > CERROR("invalid msg %p: no ptlrpc body!\n", msg);
    > }
    > - /* no break */
    > + /* fall through */
    > default:
    > return 0;
    > }
    > @@ -1035,7 +1035,7 @@ int lustre_msg_get_status(struct lustre_msg *msg)
    >
    > CERROR("invalid msg %p: no ptlrpc body!\n", msg);
    > }
    > - /* no break */
    > + /* fall through */
    > default:
    > /* status might be printed in debug code while message
    > * uninitialized
    > --
    > 2.7.4
    >

    Cheers, Andreas
    --
    Andreas Dilger
    Lustre Principal Architect
    Intel Corporation







    \
     
     \ /
      Last update: 2017-10-22 17:05    [W:7.582 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site