Messages in this thread | | | Subject | Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver | From | Dmitry Osipenko <> | Date | Wed, 18 Oct 2017 00:26:45 +0300 |
| |
On 18.10.2017 00:13, Rob Herring wrote: > On Tue, Oct 17, 2017 at 3:24 PM, Thierry Reding > <thierry.reding@gmail.com> wrote: >> On Tue, Oct 17, 2017 at 03:13:54PM -0500, Rob Herring wrote: >> [...] >>>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt >> [...] >>>> +- resets : Must contain an entry for each entry in reset-names. >>>> + See ../reset/reset.txt for details. >>>> +- reset-names : Must include the following entries: >>>> + - vde >>> >>> -names is pointless when there is only one. >> >> I'd prefer to keep it. In the past we occasionally had to add clocks or >> resets to a device tree node where only one had been present (and hence >> no -names property) and that caused some awkwardness because verbiage >> had to be added to the bindings that clarified that one particular entry >> (the original one) always had to come first. > > The order should be specified regardless of -names and the original > one has to come first if you add any. That's not awkwardness, but how > bindings work.
Probably it would be okay to remove '-names' from the binding doc, but keep them in the actual DT, wouldn't it?
| |