lkml.org 
[lkml]   [2017]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support
    On Mon, Oct 16, 2017 at 10:34:08AM -0500, Brijesh Singh wrote:
    > From: Tom Lendacky <thomas.lendacky@amd.com>
    >
    > Provide support for Secure Encrypted Virtualization (SEV). This initial
    > support defines a flag that is used by the kernel to determine if it is
    > running with SEV active.

    ...

    > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
    > index 16c5f37933a2..af7f733f6f31 100644
    > --- a/arch/x86/mm/mem_encrypt.c
    > +++ b/arch/x86/mm/mem_encrypt.c
    > @@ -42,6 +42,8 @@ static char sme_cmdline_off[] __initdata = "off";
    > u64 sme_me_mask __section(.data) = 0;
    > EXPORT_SYMBOL_GPL(sme_me_mask);
    >
    > +static bool sev_enabled __section(.data) = false;

    You need to run a patch through checkpatch everytime you change it -
    sometimes the warning makes sense, like in this case:

    ERROR: do not initialise statics to false
    #73: FILE: arch/x86/mm/mem_encrypt.c:45:
    +static bool sev_enabled __section(.data) = false;

    Please add checkpatch to a script which you run before committing. Or
    something to that effect. In any case, you should automate it so that
    you don't forget.

    Thx.

    P.S., just send a fixed version as a reply to this message.

    --
    Regards/Gruss,
    Boris.

    Good mailing practices for 400: avoid top-posting and trim the reply.

    \
     
     \ /
      Last update: 2017-10-16 18:22    [W:4.227 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site