Messages in this thread | | | Subject | Re: [RFC PATCH v2 1/8] cpuidle: menu: extract prediction functionality | From | "Li, Aubrey" <> | Date | Mon, 16 Oct 2017 10:46:20 +0800 |
| |
On 2017/10/14 8:26, Rafael J. Wysocki wrote: > On Saturday, September 30, 2017 9:20:27 AM CEST Aubrey Li wrote: >> There are several factors in the menu governor to predict the next >> idle interval: >> - the next timer >> - the recent idle interval history >> - the corrected idle interval pattern >> These factors are common enough to be extracted to be one function. >> >> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com> > > This patch alone would break things AFAICS, because it removes code from > menu_select() without a replacement (and menu_predict() is never called > just yet). > > Please always do your best to ensure that things will work after *every* > patch in a series.
okay, I'll correct this in the next version.
Thanks, -Aubrey
| |