lkml.org 
[lkml]   [2017]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] platform/x86: intel_cht_int33fe: make a couple of local functions static
From
Date
Hi,

On 12-10-17 22:36, Andy Shevchenko wrote:
> +Cc: Hans
>
> On Wed, Oct 11, 2017 at 12:30 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The functions cht_int33fe_check_for_max17047 and cht_int33fe_find_max17047
>> are local to the source and do not need to be in global scope, so make
>> them static.
>>
>> Cleans up sparse warnings:
>> symbol 'cht_int33fe_check_for_max17047' was not declared. Should it be
>> static?
>> symbol 'cht_int33fe_find_max17047' was not declared. Should it be static?
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch looks good to me, thank you for catching this:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



>> ---
>> drivers/platform/x86/intel_cht_int33fe.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c
>> index 94716b2fbc00..286c6207765d 100644
>> --- a/drivers/platform/x86/intel_cht_int33fe.c
>> +++ b/drivers/platform/x86/intel_cht_int33fe.c
>> @@ -42,7 +42,7 @@ struct cht_int33fe_data {
>> * These helpers are used to work around this by checking if an i2c-client
>> * for the max17047 has already been registered.
>> */
>> -int cht_int33fe_check_for_max17047(struct device *dev, void *data)
>> +static int cht_int33fe_check_for_max17047(struct device *dev, void *data)
>> {
>> struct i2c_client **max17047 = data;
>> struct acpi_device *adev;
>> @@ -62,7 +62,7 @@ int cht_int33fe_check_for_max17047(struct device *dev, void *data)
>> return 1;
>> }
>>
>> -struct i2c_client *cht_int33fe_find_max17047(void)
>> +static struct i2c_client *cht_int33fe_find_max17047(void)
>> {
>> struct i2c_client *max17047 = NULL;
>>
>> --
>> 2.14.1
>>
>
>
>

\
 
 \ /
  Last update: 2017-10-13 15:52    [W:0.085 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site