Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] PM / QoS: Drop PM_QOS_FLAG_REMOTE_WAKEUP | Date | Fri, 13 Oct 2017 15:04:42 +0200 |
| |
On Friday, October 13, 2017 8:32:18 AM CEST Ulf Hansson wrote: > On 13 October 2017 at 02:35, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > The PM QoS flag PM_QOS_FLAG_REMOTE_WAKEUP is not used consistently > > and the vast majority of code simply assumes that remote wakeup > > should be enabled for devices in runtime suspend if they can > > generate wakeup signals, so drop it. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > With a minor nitpick below, please add: > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > > > --- > > drivers/acpi/device_pm.c | 6 ++---- > > drivers/base/power/domain.c | 4 +--- > > drivers/base/power/sysfs.c | 28 ---------------------------- > > include/linux/pm_qos.h | 1 - > > 4 files changed, 3 insertions(+), 36 deletions(-) > > I found the flag to also be mentioned in the > Documentation/power/pm_qos_interface.txt, could please remove that > part as well.
Right, and not only there.
That's how it goes when you try to document everything dutifully. :-)
I'll send an update shortly.
Thanks, Rafael
| |