Messages in this thread | | | Date | Thu, 12 Oct 2017 17:59:42 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case |
| |
On Thu, Oct 12, 2017 at 11:31:51PM +0800, Wangnan (F) wrote:
SNIP
> > > > Ok. If it works it's fine for me. > > well it works, but it means that bpf file cannot contains any directory > > part.. which im not sure is ok with bpf folks ;-) anyone? > > Sorry I didn't see this thread these days. > > Do you think adding a special escape character to suppress BPF > name parsing in a event is a good idea? for example: > > % perf stat -e cpu/uops_executed.core,cmask=1/ true > bpf: builtin compilation failed: -95, try external compiler > ERROR: problems with path cpu/uops_executed.c: No such file or directory > event syntax error: 'cpu/uops_executed.core,cmask=1/' > \___ Failed to load cpu/uops_executed.c from source: > Error when compiling BPF scriptlet. Add a leading '@' to avoid BPF syntax > > % perf stat -e @cpu/uops_executed.core,cmask=1/ true > ... >
if we go this way, I'd rather mark the bpf syntax instead of changing the generic event format, like Andi suggested in some earlier email
but maybe we can workaround this with patch I sent in my last email
thanks, jirka
| |