Messages in this thread Patch in this message | | | From | Bhumika Goyal <> | Date | Thu, 12 Oct 2017 17:04:53 +0200 | Subject | Re: [PATCH] stm class: make config_item_type const |
| |
On Thu, Oct 12, 2017 at 2:12 PM, Bhumika Goyal <bhumirks@gmail.com> wrote: > This is a followup patch for: > https://patchwork.kernel.org/patch/9999649/ and > https://lkml.org/lkml/2017/10/11/375 > > Make config_item_type structures const as they are either passed to a > function having the argument as const or used inside a if statement or > stored in the const "ci_type" field of a config_item structure. > > Done using Coccinelle. >
Tthis patch is dependent on the patches in the links https://lkml.org/lkml/2017/10/11/375 and https://patchwork.kernel.org/patch/9999649/. Therefore, this patch won't be correct unless the patches in these links gets applied.
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > --- > drivers/hwtracing/stm/policy.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c > index 6c0ae29..33e9a1b 100644 > --- a/drivers/hwtracing/stm/policy.c > +++ b/drivers/hwtracing/stm/policy.c > @@ -187,8 +187,8 @@ static void stp_policy_node_release(struct config_item *item) > NULL, > }; > > -static struct config_item_type stp_policy_type; > -static struct config_item_type stp_policy_node_type; > +static const struct config_item_type stp_policy_type; > +static const struct config_item_type stp_policy_node_type; > > static struct config_group * > stp_policy_node_make(struct config_group *group, const char *name) > @@ -236,7 +236,7 @@ static void stp_policy_node_release(struct config_item *item) > .drop_item = stp_policy_node_drop, > }; > > -static struct config_item_type stp_policy_node_type = { > +static const struct config_item_type stp_policy_node_type = { > .ct_item_ops = &stp_policy_node_item_ops, > .ct_group_ops = &stp_policy_node_group_ops, > .ct_attrs = stp_policy_node_attrs, > @@ -311,7 +311,7 @@ static void stp_policy_release(struct config_item *item) > .make_group = stp_policy_node_make, > }; > > -static struct config_item_type stp_policy_type = { > +static const struct config_item_type stp_policy_type = { > .ct_item_ops = &stp_policy_item_ops, > .ct_group_ops = &stp_policy_group_ops, > .ct_attrs = stp_policy_attrs, > @@ -380,7 +380,7 @@ static void stp_policy_release(struct config_item *item) > .make_group = stp_policies_make, > }; > > -static struct config_item_type stp_policies_type = { > +static const struct config_item_type stp_policies_type = { > .ct_group_ops = &stp_policies_group_ops, > .ct_owner = THIS_MODULE, > }; > -- > 1.9.1 >
| |