Messages in this thread | | | Date | Thu, 12 Oct 2017 15:34:44 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] floppy: Add floppy prefix to pr_info |
| |
On Fri, 28 Jul 2017, Corentin Labbe wrote:
> When booting a qemu virtual machine I got in dmesg the following message > alone: "work still pending". > Without prefix, it is hard to know which subsystem got work pending. > > This patch add a "floppy:" prefix to this message. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > drivers/block/floppy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 9c00f29e40c1..61eb80c8894b 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -4872,7 +4872,7 @@ static void floppy_release_irq_and_dma(void) > if (delayed_work_pending(&fd_timer)) > pr_info("auxiliary floppy timer still active\n"); > if (work_pending(&floppy_work)) > - pr_info("work still pending\n"); > + pr_info("floppy: work still pending\n");
I think it'd actually be much better to fix this globally for all such instances in that file, and define pr_fmt proper. Could you please do that instead?
Thanks,
-- Jiri Kosina SUSE Labs
| |