Messages in this thread | | | Date | Wed, 11 Oct 2017 22:41:31 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory |
| |
On Wed, Oct 11, 2017 at 12:39:39PM -0700, Florian Fainelli wrote: > On 10/11/2017 01:22 AM, Abbott Liu wrote: > > diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S > > index 8733012..c17f4a2 100644 > > --- a/arch/arm/kernel/head-common.S > > +++ b/arch/arm/kernel/head-common.S > > @@ -101,7 +101,11 @@ __mmap_switched: > > str r2, [r6] @ Save atags pointer > > cmp r7, #0 > > strne r0, [r7] @ Save control register values > > +#ifdef CONFIG_KASAN > > + b kasan_early_init > > +#else > > b start_kernel > > +#endif > > Please don't make this "exclusive" just conditionally call > kasan_early_init(), remove the call to start_kernel from > kasan_early_init and keep the call to start_kernel here.
iow:
#ifdef CONFIG_KASAN bl kasan_early_init #endif b start_kernel
This has the advantage that we don't leave any stack frame from kasan_early_init() on the init task stack.
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up
| |