lkml.org 
[lkml]   [2017]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Part2 PATCH v5.1 12.4/31] crypto: ccp: Implement SEV_PLATFORM_STATUS ioctl command
From
Date


On 10/11/2017 03:28 PM, Borislav Petkov wrote:
> On Wed, Oct 11, 2017 at 03:10:49PM -0500, Brijesh Singh wrote:
>> The current 'struct sev_data_status' matches with the firmware names and the
>> bit fields. Only thing I did was the fields with no name is called as
>> "reservedX"
>
> Ok, I see it. So what you actually wanna do is:
>
> struct sev_data_status {
> u8 api_major; /* Out */
> u8 api_minor; /* Out */
> u8 state; /* Out */
> u8 flags; /* Out */
> u32 config; /* Out */
> u32 guest_count; /* Out */
> } __packed;
>

OK, if userspace is going to pick bits apart then how about this:

struct sev_data_status {
u8 api_major; /* Out */
u8 api_minor; /* Out */
u8 state; /* Out */
u32 flags; /* Out */
u8 build; /* Out */
u32 guest_count; /* Out */
} __packed;

>
> Makes sense?
>

Please let me know if you are okay with my above structure.

-Brijesh

\
 
 \ /
  Last update: 2017-10-11 22:46    [W:0.758 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site