lkml.org 
[lkml]   [2017]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.4 32/53] cifs: return ENAMETOOLONG for overlong names in cifs_open()/cifs_lookup()
From
Date
On Mon, 2017-08-28 at 10:05 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Ronnie Sahlberg <lsahlber@redhat.com>
>
> commit d3edede29f74d335f81d95a4588f5f136a9f7dcf upstream.
[...]
> @@ -505,6 +506,11 @@ cifs_atomic_open(struct inode *inode, st
>   }
>  
>   tcon = tlink_tcon(tlink);
> +
> + rc = check_name(direntry, tcon);
> + if (rc)
> + goto out_free_xid;
> +
>   server = tcon->ses->server;
>  
>   if (server->ops->new_lease_key)
[...]

Doesn't this leak a reference to tlink? Seems like the exit label
should be 'out' not 'out_free_xid'.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.

\
 
 \ /
  Last update: 2017-10-11 21:26    [W:0.192 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site